Exclude libcst 1.8.1 for Python 3.9#51606
Merged
Lee-W merged 2 commits intoapache:mainfrom Jun 11, 2025
Merged
Conversation
…is needed in Python 3.9
…ses typing-extentions
eladkal
approved these changes
Jun 11, 2025
eladkal
added
the
backport-to-v3-1-test
github-actions bot
pushed a commit
that referenced
this pull request
Jun 11, 2025
* build(pre-commit): ignore 1.8.1 as it misses typing-extensions which is needed in Python 3.9 * build(pyproject.toml): include libcst==1.8.1 for python 3.9 as it misses typing-extentions (cherry picked from commit 2bd4c17) Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Backport successfully created: v3-0-test
|
pierrejeambrun
pushed a commit
that referenced
this pull request
Jun 11, 2025
* build(pre-commit): ignore 1.8.1 as it misses typing-extensions which is needed in Python 3.9 * build(pyproject.toml): include libcst==1.8.1 for python 3.9 as it misses typing-extentions (cherry picked from commit 2bd4c17) Co-authored-by: Wei Lee <weilee.rx@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
uv run --python 3.9 --with libcst==1.8.1 python -c "from libcst.codemod import CodemodContext"fails with ModuleNotFoundError: No module named 'typing_extensions' whileuv run --python 3.10 --with libcst==1.8.1 python -c "from libcst.codemod import CodemodContext"works fine. This breakscheck-deferrable-defaulthookWhat
Exclude libcst 1.8.1 for Python 3.9
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.